Laszlo Hornyak has posted comments on this change.
Change subject: engine: unit test for VdsDeploy.getEngineSSHPublicKey
......................................................................
Patch Set 1: (1 inline comment)
will come back here later...
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 196: /**
Line 197: * Return the engine ssh public key to install on host.
Line 198: * @return ssh public key.
Line 199: */
Line 200: static String getEngineSSHPublicKey() {
ok, so the protected would give access not only to code in the same package,
but also to subclasses. this class may not have a subclass (almost everything
is static) but still wondering what is the benefit in that general parctice...
Line 201: final String keystoreFile =
Config.<String>GetValue(ConfigValues.keystoreUrl);
Line 202: final String alias =
Config.<String>GetValue(ConfigValues.CertAlias);
Line 203: final char[] password =
Config.<String>GetValue(ConfigValues.keystorePass).toCharArray();
Line 204:
--
To view, visit http://gerrit.ovirt.org/12719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5397eece5eabf81755df93c381d9bb6934b237e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
