Vojtech Szocs has posted comments on this change. Change subject: webadmin: Application continue polling after logout ......................................................................
Patch Set 7: (4 inline comments) Alex, in https://bugzilla.redhat.com/show_bug.cgi?id=888492#c0 you mentioned that after logout, last active tab has its model still doing refresh. Is this still relevant? (In this patch, we only stop refresh timers for bookmarks, roles and system permissions.) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java Line 92 Line 93 Line 94 Line 95 Line 96 IIRC this code was meant to hide visible Error popup when the user signs out. However, considering all popups are modal, user cannot sign out without closing the popup first, so I think this change is safe. .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java Line 40 Line 41 Line 42 Line 43 Line 44 Same as in BaseApplicationInit, I think this change is safe. .................................................... File frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginSectionPresenter.java Line 48 Line 49 Line 50 Line 51 Line 52 If calling super is the only thing, please remove this method override altogether. Line 56 Line 57 Line 58 Line 59 Line 60 If calling super is the only thing, please remove this method override altogether. -- To view, visit http://gerrit.ovirt.org/10895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd2718649ab4031e6ff2b0d0e6c449f53164ff9f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
