Vojtech Szocs has posted comments on this change.
Change subject: webadmin: grids jump to last selected entity
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
Line 110: private Column<T, ?> emptyNoWidthColumn;
Line 111:
Line 112: // Table container's horizontal scroll position, used to align
table header with main table
Line 113: private int tableContainerHorizontalScrollPosition = 0;
Line 114: // Table container's vertical scroll position, used to align
table header with main table
"used to align table header with main table" -> "used to retain table scroll
position after data refresh"
Line 115: private int tableContainerVerticalScrollPosition = 0;
Line 116:
Line 117: public AbstractActionTable(SearchableTableModelProvider<T, ?>
dataProvider,
Line 118: Resources resources, Resources headerRresources, EventBus
eventBus) {
Line 159: }
Line 160:
Line 161: @Override
Line 162: public void setRowData(int start, List<? extends T>
values) {
Line 163: Scheduler.get().scheduleDeferred(new
ScheduledCommand() {
I agree, for improved readability please move this code after
updateTableControls()
Line 164: @Override
Line 165: public void execute() {
Line 166:
tableContainer.getElement().setScrollTop(tableContainerVerticalScrollPosition);
Line 167: }
--
To view, visit http://gerrit.ovirt.org/10672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f34a369ba1074456614ad65b7e4cc77af963853
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
