Michael Kublin has posted comments on this change. Change subject: engine: connectStorageServer is not sent for inactive domains before connectStoragePool ......................................................................
Patch Set 1: re: The code looks good, but a question - what happens when we connect to storage pool with inactive domains? same return code is provided back, or engine does not care? - InActive it is engine status, so if host see domain it will connect to it, otherwise connection will fail. Also, InActive it is a status, which is set to domain in case that all host don't see it, when a status is set only update of db is performed, so from point of hosts domain is part of pool -- To view, visit http://gerrit.ovirt.org/12805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb3710bb83ef81485715577ae939014ffcae693f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
