Allon Mureinik has posted comments on this change.
Change subject: core: add the image block alignment scan
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ScanDiskAlignmentCommand.java
Line 83: }
Line 84:
Line 85: @Override
Line 86: protected void executeCommand() {
Line 87: ScanDiskAlignmentVDSCommandParameters parameters;
I completely missed that block somehow.
/me is blind.
Line 88:
Line 89: // At the moment we select the first VM. This could become a
live operation
Line 90: // (only relevant for non-shareabale images) and we might want
to pick one
Line 91: // of the running VM.
Line 138: if (permsList == null && getDisk() != null) {
Line 139: permsList = new ArrayList<PermissionSubject>();
Line 140: permsList.add(new PermissionSubject(getDisk().getId(),
Line 141: VdcObjectType.Disk,
Line 142: ActionGroup.ATTACH_DISK));
EDIT_DISK_PROPERTIES seems to be the correct permission.
IMHO, the ATTACH_DISK is redundant and wrong.
Line 143: }
Line 144: return permsList;
Line 145: }
Line 146:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ScanDiskAlignmentParameters.java
Line 1: package org.ovirt.engine.core.common.action;
Line 2:
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class ScanDiskAlignmentParameters extends
VdcActionParametersBase {
I think that's a bit overkilling it.
If someone wants to pass a different class, with extra members we're ignoring,
it's his own problem.
Line 6: private static final long serialVersionUID = -6587274019503875891L;
Line 7:
Line 8: public ScanDiskAlignmentParameters(Guid diskId) {
Line 9: setEntityId(diskId);
--
To view, visit http://gerrit.ovirt.org/11946
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4858b7bbfa453230fcafecfbc5358c715d5d825b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
