ofri masad has uploaded a new change for review.
Change subject: webadmin: Clean-up and documentation
......................................................................
webadmin: Clean-up and documentation
Added Documentation to EnumRenderer
Clean-up for AbstractVmPopupWidget.ui.xml
Change-Id: I96adcacf5e5b0eb47c59772b7cb9383e0d10283f
Signed-off-by: Ofri Masad <oma...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/EnumRenderer.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
2 files changed, 197 insertions(+), 178 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/12757/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/EnumRenderer.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/EnumRenderer.java
index 81c2924..63bde1a 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/EnumRenderer.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/EnumRenderer.java
@@ -1,12 +1,18 @@
package org.ovirt.engine.ui.common.widget.renderer;
import org.ovirt.engine.ui.uicompat.EnumTranslator;
-
import com.google.gwt.text.shared.AbstractRenderer;
/**
* Renderer for Enum values.
*
+ * To use this EnumRenderer:
+ * - Add an entry for each enum value to {@link
org.ovirt.engine.ui.uicompat.Enums} in the
+ * form of ClassName___ValueName
+ * - Add an entry for each enum value to
+ *
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
+ * with the desired string value
+ *
* @param <E>
* Enum type.
*/
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
index b8ee1e6..e8767e1 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
@@ -1,15 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent";>
<ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder"
xmlns:g="urn:import:com.google.gwt.user.client.ui"
- xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog"
- xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor"
- xmlns:t="urn:import:org.ovirt.engine.ui.common.widget.dialog.tab"
-
xmlns:s="urn:import:org.ovirt.engine.ui.common.widget.uicommon.storage"
-
xmlns:k="urn:import:org.ovirt.engine.ui.common.widget.form.key_value">
+
xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog"
+
xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor"
+
xmlns:t="urn:import:org.ovirt.engine.ui.common.widget.dialog.tab"
+
xmlns:s="urn:import:org.ovirt.engine.ui.common.widget.uicommon.storage"
+
xmlns:k="urn:import:org.ovirt.engine.ui.common.widget.form.key_value">
- <ui:with field='constants'
type='org.ovirt.engine.ui.common.CommonApplicationConstants'/>
+ <ui:with field='constants'
type='org.ovirt.engine.ui.common.CommonApplicationConstants'/>
- <ui:style
type="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget.Style">
+ <ui:style
type="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget.Style">
.generalTabTopDecorator {
background-color: #D3D3D3;
margin-top: 4px;
@@ -54,11 +54,11 @@
padding-right: 25px;
}
- .provisioningEditorContent {
+ .provisioningEditorContent {
display: none;
}
- .provisioningRadioContent {
+ .provisioningRadioContent {
padding-top: 3px;
width: 100%;
}
@@ -74,53 +74,45 @@
padding-bottom: 10px;
}
- .textBox {
- width: 30px;
- float: right;
- }
+ .textBox {
+ width: 30px;
+ float: right;
+ }
- .numOfVmsLabel {
- margin-left: 5px;
- color: #333333;
- }
+ .numOfVmsLabel {
+ margin-left: 5px;
+ color: #333333;
+ }
- .assignedVmsLabel {
- margin-left: 8px;
- }
+ .assignedVmsLabel {
+ margin-left: 8px;
+ }
- .prestartedHintLabel {
- font-size: 7pt;
- color: gray;
- text-align: right;
- }
-
- .radioButton {
-
+ .prestartedHintLabel {
+ font-size: 7pt;
+ color: gray;
+ text-align: right;
}
.radioButtonSpecificHost {
- margin-left: 5px;
+ margin-left: 5px;
}
.label {
width: 350px;
}
- .labelDisabled {
- color: gray;
- }
-
- .runHostPanel {
-
+ .labelDisabled {
+ color: gray;
}
.attachCdPanel {
width: 100%;
}
- .cdAttachedLabelWidth {
- width: 30px;
- }
+ .cdAttachedLabelWidth {
+ width: 30px;
+ }
.hostRunMigrationOptions {
margin-left: 6px;
@@ -139,71 +131,68 @@
width: 300px;
}
- .cpuPinningStyle {
- }
-
.expanderContent,.generalExpanderContent {
padding-left: 10px;
}
-
+
.expanderContent {
float: left;
}
.warningLabel {
- color: red;
- font-weight: bold;
- margin-bottom: 10px;
- }
-
- .poolEditVms, .name {
+ color: red;
+ font-weight: bold;
+ margin-bottom: 10px;
+ }
+
+ .poolEditVms, .name {
line-height: 30px;
padding: 0 5px;
padding-bottom: 35px;
- }
-
- .prestartedVmsEditorContent,.nameEditorContent {
- width: 230px;
- }
-
- .prestartedVmsEditor,.nameEditor {
- float: right;
- width: 230px;
- }
-
- .editPrestartedVmsEditor {
- float: left;
- padding-right: 10px;
- }
-
- .prestartedVmsIcon, .poolNameIcon {
- float: left;
- padding-top: 5px;
- padding-left: 2px;
- }
-
- .prestartedLabelWithHelp,.increasePrestartedLabel {
- float: left;
- }
+ }
- .editPrestartedVms,.editIncreaseVms {
- float: right;
- width: 230px;
- }
-
- .prestartedLabel, .nameLabel {
- float: left;
- color: #333333;
- }
-
- .increaseVmsInPoolVms {
- float: left;
- }
+ .prestartedVmsEditorContent,.nameEditorContent {
+ width: 230px;
+ }
+
+ .prestartedVmsEditor,.nameEditor {
+ float: right;
+ width: 230px;
+ }
+
+ .editPrestartedVmsEditor {
+ float: left;
+ padding-right: 10px;
+ }
+
+ .prestartedVmsIcon, .poolNameIcon {
+ float: left;
+ padding-top: 5px;
+ padding-left: 2px;
+ }
+
+ .prestartedLabelWithHelp,.increasePrestartedLabel {
+ float: left;
+ }
+
+ .editPrestartedVms,.editIncreaseVms {
+ float: right;
+ width: 230px;
+ }
+
+ .prestartedLabel, .nameLabel {
+ float: left;
+ color: #333333;
+ }
+
+ .increaseVmsInPoolVms {
+ float: left;
+ }
.migrationSelect {
margin-right: 174px;
}
-
+
</ui:style>
<t:DialogTabPanel width="100%" height="100%">
@@ -212,71 +201,83 @@
<t:content>
<g:FlowPanel>
<g:FlowPanel
addStyleNames="{style.generalTabTopDecorator}">
-
<e:ListModelListBoxEditor ui:field="dataCenterEditor" />
-
<e:ListModelListBoxEditor ui:field="clusterEditor" />
-
<e:ListModelListBoxEditor ui:field="quotaEditor" />
+
<e:ListModelListBoxEditor ui:field="dataCenterEditor"/>
+
<e:ListModelListBoxEditor ui:field="clusterEditor"/>
+
<e:ListModelListBoxEditor ui:field="quotaEditor"/>
</g:FlowPanel>
<g:FlowPanel
addStyleNames="{style.sectionPanel}">
<g:FlowPanel
addStyleNames="{style.name}">
<g:FlowPanel
addStyleNames="{style.prestartedLabelWithHelp}">
-
<g:Label ui:field="nameLabel" addStyleNames="{style.nameLabel}" />
-
<d:InfoIcon ui:field="poolNameIcon" addStyleNames="{style.poolNameIcon}" />
+
<g:Label ui:field="nameLabel" addStyleNames="{style.nameLabel}"/>
+
<d:InfoIcon ui:field="poolNameIcon" addStyleNames="{style.poolNameIcon}"/>
</g:FlowPanel>
-
<e:EntityModelTextBoxOnlyEditor ui:field="nameEditor"
addStyleNames="{style.nameEditor}"
contentWidgetStyleName="{style.nameEditorContent}"/>
+
<e:EntityModelTextBoxOnlyEditor ui:field="nameEditor"
addStyleNames="{style.nameEditor}"
+
contentWidgetStyleName="{style.nameEditorContent}"/>
</g:FlowPanel>
-
<e:EntityModelTextBoxEditor ui:field="descriptionEditor" />
+
<e:EntityModelTextBoxEditor ui:field="descriptionEditor"/>
-<!-- New VM Pool
-->
-
<e:EntityModelTextBoxEditor ui:field="numOfVmsEditor" />
- <g:FlowPanel ui:field="newPoolEditVmsPanel"
addStyleNames="{style.poolEditVms}">
- <g:FlowPanel
addStyleNames="{style.prestartedLabelWithHelp}">
-
<g:Label ui:field="prestartedLabel" addStyleNames="{style.prestartedLabel}" />
-
<d:InfoIcon ui:field="newPoolPrestartedVmsIcon"
addStyleNames="{style.prestartedVmsIcon}" />
- </g:FlowPanel>
-
<e:EntityModelTextBoxOnlyEditor ui:field="prestartedVmsEditor"
addStyleNames="{style.prestartedVmsEditor}"
contentWidgetStyleName="{style.prestartedVmsEditorContent}" />
- </g:FlowPanel>
-
-<!-- Edit VM Pool -->
- <g:FlowPanel addStyleNames="{style.poolEditVms}"
ui:field="editPoolEditVmsPanel">
+ <!--
New VM Pool
-->
+
<e:EntityModelTextBoxEditor ui:field="numOfVmsEditor"/>
+ <g:FlowPanel
ui:field="newPoolEditVmsPanel" addStyleNames="{style.poolEditVms}">
<g:FlowPanel
addStyleNames="{style.prestartedLabelWithHelp}">
-
<g:Label ui:field="editPrestartedVmsLabel"
addStyleNames="{style.prestartedLabel}" />
-
<d:InfoIcon ui:field="editPoolPrestartedVmsIcon"
addStyleNames="{style.prestartedVmsIcon}" />
+
<g:Label ui:field="prestartedLabel" addStyleNames="{style.prestartedLabel}"/>
+
<d:InfoIcon ui:field="newPoolPrestartedVmsIcon"
+
addStyleNames="{style.prestartedVmsIcon}"/>
+ </g:FlowPanel>
+
<e:EntityModelTextBoxOnlyEditor ui:field="prestartedVmsEditor"
+
addStyleNames="{style.prestartedVmsEditor}"
+
contentWidgetStyleName="{style.prestartedVmsEditorContent}"/>
+ </g:FlowPanel>
+
+ <!--
Edit VM Pool -->
+ <g:FlowPanel
addStyleNames="{style.poolEditVms}" ui:field="editPoolEditVmsPanel">
+ <g:FlowPanel
addStyleNames="{style.prestartedLabelWithHelp}">
+
<g:Label ui:field="editPrestartedVmsLabel"
addStyleNames="{style.prestartedLabel}"/>
+
<d:InfoIcon ui:field="editPoolPrestartedVmsIcon"
+
addStyleNames="{style.prestartedVmsIcon}"/>
</g:FlowPanel>
<g:FlowPanel
addStyleNames="{style.editPrestartedVms}">
-
<e:EntityModelTextBoxOnlyEditor ui:field="editPrestartedVmsEditor"
addStyleNames="{style.editPrestartedVmsEditor}"
contentWidgetStyleName="{style.textBox}" />
-
<g:ValueLabel ui:field="outOfxInPool" />
+
<e:EntityModelTextBoxOnlyEditor ui:field="editPrestartedVmsEditor"
+
addStyleNames="{style.editPrestartedVmsEditor}"
+
contentWidgetStyleName="{style.textBox}"/>
+
<g:ValueLabel ui:field="outOfxInPool"/>
</g:FlowPanel>
- </g:FlowPanel>
-
- <g:FlowPanel
ui:field="editPoolIncraseNumOfVmsPanel" addStyleNames="{style.poolEditVms}">
- <g:Label
text="{constants.increaseNumberOfVMsInPoolBy}"
addStyleNames="{style.increasePrestartedLabel}" />
+ </g:FlowPanel>
+
+ <g:FlowPanel
ui:field="editPoolIncraseNumOfVmsPanel" addStyleNames="{style.poolEditVms}">
+ <g:Label
text="{constants.increaseNumberOfVMsInPoolBy}"
+
addStyleNames="{style.increasePrestartedLabel}"/>
<g:FlowPanel
addStyleNames="{style.editIncreaseVms}">
-
<e:EntityModelTextBoxOnlyEditor ui:field="incraseNumOfVmsEditor"
addStyleNames="{style.editPrestartedVmsEditor}"
contentWidgetStyleName="{style.textBox}" />
-
<g:Label text="{constants.vms}" addStyleNames="{style.increaseVmsInPoolVms}" />
+
<e:EntityModelTextBoxOnlyEditor ui:field="incraseNumOfVmsEditor"
+
addStyleNames="{style.editPrestartedVmsEditor}"
+
contentWidgetStyleName="{style.textBox}"/>
+
<g:Label text="{constants.vms}" addStyleNames="{style.increaseVmsInPoolVms}"/>
</g:FlowPanel>
- </g:FlowPanel>
- <e:ListModelListBoxEditor
ui:field="templateEditor"/>
- </g:FlowPanel>
- <g:FlowPanel addStyleNames="{style.sectionPanel}">
- <e:EntityModelTextBoxEditor
ui:field="memSizeEditor"/>
- <e:EntityModelTextBoxEditor
ui:field="totalvCPUsEditor" />
+ </g:FlowPanel>
+
<e:ListModelListBoxEditor ui:field="templateEditor"/>
+ </g:FlowPanel>
+ <g:FlowPanel
addStyleNames="{style.sectionPanel}">
+
<e:EntityModelTextBoxEditor ui:field="memSizeEditor"/>
+
<e:EntityModelTextBoxEditor ui:field="totalvCPUsEditor"/>
<g:FlowPanel
addStyleNames="{style.sectionPanel}">
<d:AdvancedParametersExpander ui:field="generalAdvancedParameterExpander"/>
- <g:FlowPanel
ui:field="generalAdvancedParameterExpanderContent"
addStyleNames="{style.generalExpanderContent}">
-
<e:ListModelListBoxEditor ui:field="corePerSocketEditor" />
-
<e:ListModelListBoxEditor ui:field="numOfSocketsEditor" />
+ <g:FlowPanel
ui:field="generalAdvancedParameterExpanderContent"
+
addStyleNames="{style.generalExpanderContent}">
+
<e:ListModelListBoxEditor ui:field="corePerSocketEditor"/>
+
<e:ListModelListBoxEditor ui:field="numOfSocketsEditor"/>
</g:FlowPanel>
</g:FlowPanel>
</g:FlowPanel>
<g:FlowPanel
addStyleNames="{style.sectionPanel}">
-
<e:ListModelListBoxEditor ui:field="oSTypeEditor" />
-
<e:EntityModelCheckBoxEditor ui:field="isStatelessEditor"
addStyleNames="{style.checkbox}" />
-
<e:EntityModelCheckBoxEditor ui:field="isDeleteProtectedEditor"
addStyleNames="{style.checkbox}" />
+
<e:ListModelListBoxEditor ui:field="oSTypeEditor"/>
+
<e:EntityModelCheckBoxEditor ui:field="isStatelessEditor"
addStyleNames="{style.checkbox}"/>
+
<e:EntityModelCheckBoxEditor ui:field="isDeleteProtectedEditor"
+
addStyleNames="{style.checkbox}"/>
</g:FlowPanel>
<g:FlowPanel
addStyleNames="{style.sectionPanel}">
-
+
</g:FlowPanel>
- <g:Label
ui:field="generalWarningMessage" addStyleNames="{style.warningMessageLabel}" />
+ <g:Label
ui:field="generalWarningMessage" addStyleNames="{style.warningMessageLabel}"/>
</g:FlowPanel>
</t:content>
</t:DialogTab>
@@ -285,19 +286,19 @@
<t:DialogTab ui:field="poolTab">
<t:content>
<g:FlowPanel>
- <e:ListModelListBoxEditor
ui:field="poolTypeEditor" />
+ <e:ListModelListBoxEditor
ui:field="poolTypeEditor"/>
</g:FlowPanel>
</t:content>
</t:DialogTab>
</t:tab>
<t:tab>
- <t:DialogTab ui:field="initialRunTab">
+ <t:DialogTab ui:field="initialRunTab">
<t:content>
<g:FlowPanel>
- <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.initialRunGeneral}" />
- <e:ListModelListBoxEditor
ui:field="timeZoneEditor" />
- <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.initialRunWindows}" />
- <e:ListModelListBoxEditor
ui:field="domainEditor" />
+ <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.initialRunGeneral}"/>
+ <e:ListModelListBoxEditor
ui:field="timeZoneEditor"/>
+ <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.initialRunWindows}"/>
+ <e:ListModelListBoxEditor
ui:field="domainEditor"/>
</g:FlowPanel>
</t:content>
</t:DialogTab>
@@ -306,15 +307,18 @@
<t:DialogTab ui:field="consoleTab">
<t:content>
<g:FlowPanel>
- <e:ListModelListBoxEditor
ui:field="displayProtocolEditor" />
- <e:ListModelListBoxEditor
ui:field="usbSupportEditor" />
- <e:ListModelListBoxEditor
ui:field="numOfMonitorsEditor" />
- <e:EntityModelCheckBoxEditor
ui:field="isSmartcardEnabledEditor" addStyleNames="{style.checkbox}" />
- <g:Label
ui:field="nativeUsbWarningMessage" text="{constants.nativeUsbSupportWarning}"
addStyleNames="{style.warningMessageLabel}" />
+ <e:ListModelListBoxEditor
ui:field="displayProtocolEditor"/>
+ <e:ListModelListBoxEditor
ui:field="usbSupportEditor"/>
+ <e:ListModelListBoxEditor
ui:field="numOfMonitorsEditor"/>
+ <e:EntityModelCheckBoxEditor
ui:field="isSmartcardEnabledEditor"
+
addStyleNames="{style.checkbox}"/>
+ <g:Label
ui:field="nativeUsbWarningMessage" text="{constants.nativeUsbSupportWarning}"
+
addStyleNames="{style.warningMessageLabel}"/>
<d:AdvancedParametersExpander
ui:field="expander"/>
<g:FlowPanel
ui:field="expanderContent" addStyleNames="{style.expanderContent}">
- <g:Label
addStyleNames="{style.warningLabel}" text="{constants.advancedOptionsLabel}" />
-
<e:EntityModelCheckBoxEditor ui:field="allowConsoleReconnectEditor"
addStyleNames="{style.checkboxWithLongLabel}" />
+ <g:Label
addStyleNames="{style.warningLabel}" text="{constants.advancedOptionsLabel}"/>
+
<e:EntityModelCheckBoxEditor ui:field="allowConsoleReconnectEditor"
+
addStyleNames="{style.checkboxWithLongLabel}"/>
</g:FlowPanel>
</g:FlowPanel>
</t:content>
@@ -324,23 +328,24 @@
<t:DialogTab ui:field="hostTab">
<t:content>
<g:FlowPanel>
- <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.runOnVmPopup}" />
- <g:VerticalPanel
addStyleNames="{style.runHostPanel}" verticalAlignment='ALIGN_MIDDLE'>
-
<e:EntityModelRadioButtonEditor width="150px" ui:field="isAutoAssignEditor"
-
addStyleNames="{style.radioButton}" />
- <g:HorizontalPanel
verticalAlignment='ALIGN_MIDDLE'>
- <g:RadioButton ui:field="specificHost"
addStyleNames="{style.radioButtonSpecificHost}" />
- <g:Label ui:field="specificHostLabel"
text="{constants.specificVmPopup}" />
- <e:ListModelListBoxEditor
ui:field="defaultHostEditor" />
- </g:HorizontalPanel>
+ <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.runOnVmPopup}"/>
+ <g:VerticalPanel
verticalAlignment='ALIGN_MIDDLE'>
+
<e:EntityModelRadioButtonEditor width="150px" ui:field="isAutoAssignEditor"/>
+ <g:HorizontalPanel
verticalAlignment='ALIGN_MIDDLE'>
+ <g:RadioButton
ui:field="specificHost" addStyleNames="{style.radioButtonSpecificHost}"/>
+ <g:Label
ui:field="specificHostLabel" text="{constants.specificVmPopup}"/>
+
<e:ListModelListBoxEditor ui:field="defaultHostEditor"/>
+ </g:HorizontalPanel>
</g:VerticalPanel>
- <g:Label
addStyleNames="{style.sectionLabel}"
text="{constants.runMigrationOptionsVmPopup}" />
+ <g:Label
addStyleNames="{style.sectionLabel}"
text="{constants.runMigrationOptionsVmPopup}"/>
<g:VerticalPanel width="100%"
addStyleNames="{style.hostRunMigrationOptions}">
-
<e:ListModelListBoxEditor ui:field="migrationModeEditor"
addStyleNames="{style.migrationSelect}"/>
-
<e:EntityModelCheckBoxEditor ui:field="hostCpuEditor"
addStyleNames="{style.checkbox}" />
+
<e:ListModelListBoxEditor ui:field="migrationModeEditor"
+
addStyleNames="{style.migrationSelect}"/>
+
<e:EntityModelCheckBoxEditor ui:field="hostCpuEditor"
addStyleNames="{style.checkbox}"/>
</g:VerticalPanel>
- <e:EntityModelTextBoxEditor
ui:field="cpuPinning" addStyleNames="{style.cpuPinningStyle}"/>
- <g:HTML
ui:field="cpuPinningLabel"
addStyleNames="{style.explanationLabel},generalDialogComment" />
+ <e:EntityModelTextBoxEditor
ui:field="cpuPinning"/>
+ <g:HTML
ui:field="cpuPinningLabel"
+
addStyleNames="{style.explanationLabel},generalDialogComment"/>
</g:FlowPanel>
</t:content>
</t:DialogTab>
@@ -350,11 +355,13 @@
<t:content>
<g:FlowPanel>
<g:FlowPanel
addStyleNames="{style.sectionPanel}">
-
<e:EntityModelCheckBoxEditor ui:field="isHighlyAvailableEditor"
addStyleNames="{style.checkbox}" />
+
<e:EntityModelCheckBoxEditor ui:field="isHighlyAvailableEditor"
+
addStyleNames="{style.checkbox}"/>
</g:FlowPanel>
<g:FlowPanel
addStyleNames="{style.sectionPanel}">
- <g:Label
addStyleNames="{style.sectionLabel}"
text="{constants.priorForRunMigrationQueueVmPopup}" />
- <e:EntityModelCellTable
ui:field="priorityEditor" />
+ <g:Label
addStyleNames="{style.sectionLabel}"
+
text="{constants.priorForRunMigrationQueueVmPopup}"/>
+ <e:EntityModelCellTable
ui:field="priorityEditor"/>
</g:FlowPanel>
</g:FlowPanel>
</t:content>
@@ -365,25 +372,30 @@
<t:content>
<g:FlowPanel>
<g:FlowPanel
addStyleNames="{style.sectionPanel}">
- <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.memAllocVmPopup}" />
-
<e:EntityModelTextBoxEditor ui:field="minAllocatedMemoryEditor" />
+ <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.memAllocVmPopup}"/>
+
<e:EntityModelTextBoxEditor ui:field="minAllocatedMemoryEditor"/>
</g:FlowPanel>
<g:FlowPanel
ui:field="storageAllocationPanel" addStyleNames="{style.sectionPanel}">
<g:HorizontalPanel>
- <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.storageAllocVmPopup}" />
- <g:Label
addStyleNames="{style.sectionComment}"
text="{constants.availOnlyTemplSelectedVmPopup}" />
+ <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.storageAllocVmPopup}"/>
+ <g:Label
addStyleNames="{style.sectionComment}"
+
text="{constants.availOnlyTemplSelectedVmPopup}"/>
</g:HorizontalPanel>
<g:HorizontalPanel
ui:field="provisionSelectionPanel">
-
<e:ListModelListBoxEditor ui:field="provisioningEditor"
addStyleNames="{style.provisioningEditor}" />
+
<e:ListModelListBoxEditor ui:field="provisioningEditor"
+
addStyleNames="{style.provisioningEditor}"/>
<g:VerticalPanel>
<e:EntityModelRadioButtonEditor ui:field="provisioningThinEditor"/>
<e:EntityModelRadioButtonEditor ui:field="provisioningCloneEditor"/>
</g:VerticalPanel>
</g:HorizontalPanel>
<g:FlowPanel
ui:field="disksAllocationPanel">
- <g:Label
ui:field="disksAllocationLabel" text="{constants.disksAllocation}"
addStyleNames="{style.disksAllocation}" visible="false" />
+ <g:Label
ui:field="disksAllocationLabel" text="{constants.disksAllocation}"
+
addStyleNames="{style.disksAllocation}" visible="false"/>
<g:VerticalPanel>
-
<s:DisksAllocationView ui:field="disksAllocationView" listHeight="170px"
listWidth="490px" showVolumeType="true"
addStyleNames="{style.disksAllocationPanel}" />
+
<s:DisksAllocationView ui:field="disksAllocationView" listHeight="170px"
+
listWidth="490px" showVolumeType="true"
+
addStyleNames="{style.disksAllocationPanel}"/>
</g:VerticalPanel>
</g:FlowPanel>
</g:FlowPanel>
@@ -396,19 +408,20 @@
<t:content>
<g:FlowPanel>
<g:FlowPanel
addStyleNames="{style.sectionPanel}">
- <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.bootSequenceVmPopup}" />
-
<e:ListModelListBoxEditor ui:field="firstBootDeviceEditor" />
-
<e:ListModelListBoxEditor ui:field="secondBootDeviceEditor" />
+ <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.bootSequenceVmPopup}"/>
+
<e:ListModelListBoxEditor ui:field="firstBootDeviceEditor"/>
+
<e:ListModelListBoxEditor ui:field="secondBootDeviceEditor"/>
<g:HorizontalPanel
addStyleNames="{style.attachCdPanel}" verticalAlignment="ALIGN_MIDDLE">
-
<e:EntityModelCheckBoxEditor label="{constants.attachCdVmPopup}"
ui:field="cdAttachedEditor" />
-
<e:ListModelListBoxEditor ui:field="cdImageEditor" />
+
<e:EntityModelCheckBoxEditor label="{constants.attachCdVmPopup}"
+
ui:field="cdAttachedEditor"/>
+
<e:ListModelListBoxEditor ui:field="cdImageEditor"/>
</g:HorizontalPanel>
</g:FlowPanel>
<g:FlowPanel
ui:field="linuxBootOptionsPanel" addStyleNames="{style.sectionPanel}">
- <g:Label
addStyleNames="{style.sectionLabel}" text="{constants.linuxBootOptionsVmPopup}"
/>
-
<e:EntityModelTextBoxEditor ui:field="kernel_pathEditor" />
-
<e:EntityModelTextBoxEditor ui:field="initrd_pathEditor" />
-
<e:EntityModelTextBoxEditor ui:field="kernel_parametersEditor" />
+ <g:Label
addStyleNames="{style.sectionLabel}"
text="{constants.linuxBootOptionsVmPopup}"/>
+
<e:EntityModelTextBoxEditor ui:field="kernel_pathEditor"/>
+
<e:EntityModelTextBoxEditor ui:field="initrd_pathEditor"/>
+
<e:EntityModelTextBoxEditor ui:field="kernel_parametersEditor"/>
</g:FlowPanel>
</g:FlowPanel>
</t:content>
@@ -418,7 +431,7 @@
<t:DialogTab ui:field="customPropertiesTab">
<t:content>
<g:FlowPanel>
- <k:KeyValueWidget
ui:field="customPropertiesSheetEditor"/>
+ <k:KeyValueWidget
ui:field="customPropertiesSheetEditor"/>
</g:FlowPanel>
</t:content>
</t:DialogTab>
--
To view, visit http://gerrit.ovirt.org/12757
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96adcacf5e5b0eb47c59772b7cb9383e0d10283f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
