Alissa Bonas has uploaded a new change for review. Change subject: core: remove unused imports in several classes ......................................................................
core: remove unused imports in several classes Removed unused import statements in several classes. Change-Id: I8d7fa3143d692fd337165f8d8ed26d9941fde97e Signed-off-by: Alissa Bonas <abo...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateImportExportParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkNonOperationalQueryParamenters.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/searchbackend/DateUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendQueryAsyncResult.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java 7 files changed, 26 insertions(+), 34 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/12756/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateImportExportParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateImportExportParameters.java index 1f7ff1c..8deddd9 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateImportExportParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateImportExportParameters.java @@ -3,8 +3,6 @@ import org.ovirt.engine.core.compat.*; import org.ovirt.engine.core.common.businessentities.*; -import org.ovirt.engine.core.common.queries.*; - import java.util.List; import java.util.LinkedList; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkNonOperationalQueryParamenters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkNonOperationalQueryParamenters.java index 315379f..59bba96 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkNonOperationalQueryParamenters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkNonOperationalQueryParamenters.java @@ -1,7 +1,6 @@ package org.ovirt.engine.core.common.queries; import org.ovirt.engine.core.compat.*; -import org.ovirt.engine.core.common.businessentities.*; import org.ovirt.engine.core.common.businessentities.network.Network; public class NetworkNonOperationalQueryParamenters extends VdcQueryParametersBase { diff --git a/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java b/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java index eb9c090..4331230 100644 --- a/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java +++ b/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java @@ -2,7 +2,6 @@ import java.io.Serializable; -import com.google.gwt.regexp.shared.MatchResult; import com.google.gwt.regexp.shared.RegExp; public class TimeSpan implements Comparable<TimeSpan>, Serializable diff --git a/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/searchbackend/DateUtils.java b/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/searchbackend/DateUtils.java index 35a85c7..f73b755 100644 --- a/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/searchbackend/DateUtils.java +++ b/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/searchbackend/DateUtils.java @@ -6,7 +6,6 @@ import org.ovirt.engine.core.compat.DateTime; import java.text.DateFormat; -import java.util.Calendar; import java.util.Date; class DateUtils { diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java index abd0a55..f5dd868 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java @@ -1,6 +1,5 @@ package org.ovirt.engine.ui.uicompat; -import org.ovirt.engine.core.compat.*; public class EventProvidingCollection<T> extends ObservableCollection<T> implements IProvideCollectionChangedEvent { diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendQueryAsyncResult.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendQueryAsyncResult.java index 0ed8d3d..1bc0020 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendQueryAsyncResult.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendQueryAsyncResult.java @@ -1,6 +1,5 @@ package org.ovirt.engine.ui.uicompat; -import org.ovirt.engine.core.common.queries.SearchParameters; import org.ovirt.engine.core.common.queries.VdcQueryParametersBase; import org.ovirt.engine.core.common.queries.VdcQueryReturnValue; import org.ovirt.engine.core.common.queries.VdcQueryType; diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java index 04d789d..b2cbcbb 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java @@ -20,9 +20,8 @@ //package org.apache.commons.codec.binary; import java.io.UnsupportedEncodingException; -import java.util.ArrayList; -import java.util.Iterator; -import java.util.List; +import java.util.Iterator; +import java.util.List; //import org.apache.commons.codec.CharEncoding; @@ -281,28 +280,28 @@ return StringUtils.newString(bytes, CharEncoding.UTF_8); } - /** - * Joins the Strings of the provided array into a single String. - * - * @param array the array of Strings to join together - * @param delimiter the separator string to use - * @return - */ - public static String join(List<String> list, String delimiter) { - if (list == null) { - return ""; - } - - StringBuilder builder = new StringBuilder(); - Iterator<String> iter = list.iterator(); - while (iter.hasNext()) { - builder.append(iter.next()); - if (!iter.hasNext()) { - break; - } - builder.append(delimiter); - } - return builder.toString(); - } - + /** + * Joins the Strings of the provided array into a single String. + * + * @param array the array of Strings to join together + * @param delimiter the separator string to use + * @return + */ + public static String join(List<String> list, String delimiter) { + if (list == null) { + return ""; + } + + StringBuilder builder = new StringBuilder(); + Iterator<String> iter = list.iterator(); + while (iter.hasNext()) { + builder.append(iter.next()); + if (!iter.hasNext()) { + break; + } + builder.append(delimiter); + } + return builder.toString(); + } + } -- To view, visit http://gerrit.ovirt.org/12756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8d7fa3143d692fd337165f8d8ed26d9941fde97e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches