Sandro Bonazzola has posted comments on this change. Change subject: tools: fixed --version output ......................................................................
Patch Set 4: (1 inline comment) .................................................... File src/config.py.in.in Line 11: DEFAULT_CA_PEM = "@sysconfdir_POST@/pki/ovirt-engine/ca.pem" Line 12: DEFAULT_SSH_KEY = "@sysconfdir_POST@/pki/ovirt-engine/keys/engine_id_rsa" Line 13: DEFAULT_CONFIGURATION_FILE = "@engineconfigdir_POST@/logcollector.conf" Line 14: DEFAULT_LOG_FILE = "@localstatedir_POST@/log/ovirt-engine/engine-log-collector.log" Line 15: DEFAULT_SCRATCH_DIR = tempfile.mktemp(prefix='logcollector-', dir="@localstatedir_POST@/tmp") Don't worry, I like constructive criticism. I'll use LOCALSTATEDIR here and move the mktemp in __main__. I'll use mkdtemp also if I would have liked to avoid to cleanup that dir just after a --help command... -- To view, visit http://gerrit.ovirt.org/12735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88f53765028284221a0506efbc595b146a2bca8a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
