Sandro Bonazzola has posted comments on this change.

Change subject: tools: fixed --version output
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File configure.ac
Line 75: 
Line 76: AC_CONFIG_FILES([
Line 77:        Makefile
Line 78:        ovirt-log-collector.spec
Line 79:        src/config.py.in
no, it creates src/config.py.in from src/config.py.in.in as 
ovirt-log-collector.spec is created from ovirt-log-collector.spec.in
Line 80:        src/Makefile
Line 81:        src/sos/Makefile
Line 82:        src/sos/plugins/Makefile
Line 83:        src/helper/Makefile


--
To view, visit http://gerrit.ovirt.org/12735
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88f53765028284221a0506efbc595b146a2bca8a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to