Yair Zaslavsky has posted comments on this change.
Change subject: engine : Refactoring Async tasks code
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/taskmgr/AsyncTaskUtils.java
Line 6:
Line 7: /**
Line 8: * Helper class for async tasks handling
Line 9: */
Line 10: public class AsyncTaskUtils {
We have two utils classes.
Maybe eliminate this and move the helper to the class you created?
What do you think?
Line 11:
Line 12: /**
Line 13: * Adds a task to DB or updates it if already
Line 14: * exists in DB
--
To view, visit http://gerrit.ovirt.org/12693
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d2770f355274159c30def80c7c263bb590a64f7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
