Ravi Nori has posted comments on this change.
Change subject: engine : Refactoring Async tasks code
......................................................................
Patch Set 2: No score
(2 inline comments)
Will submit a patch to topic branch with the changes
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1303: */
Line 1304: protected Guid createTask(AsyncTaskCreationInfo
asyncTaskCreationInfo,
Line 1305: VdcActionType parentCommand,
Line 1306: String description, VdcObjectType entityType, Guid...
entityIds) {
Line 1307: return TasksUtil.createTask(this, asyncTaskCreationInfo,
parentCommand, description, entityType, entityIds);
Lets take it one step at a time.
Line 1308: }
Line 1309:
Line 1310: public SPMAsyncTask concreteCreateTask(
Line 1311: AsyncTaskCreationInfo asyncTaskCreationInfo,
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TasksUtil.java
Line 1: /*
Line 2: * To change this template, choose Tools | Templates
Line 3: * and open the template in the editor.
Line 4: */
Line 5: package org.ovirt.engine.core.bll.tasks;
How about taskmgr?
Line 6:
Line 7: import java.util.ArrayList;
Line 8: import javax.transaction.Transaction;
Line 9: import org.ovirt.engine.core.bll.CommandBase;
--
To view, visit http://gerrit.ovirt.org/12561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3839ed09825f1e0db914f55f5ee358b6b3c0449
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
