Liron Aravot has posted comments on this change.

Change subject: [wip] core: storage domain failover process never runs
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
Line 84:         // when the execution is internal, proceed also if the domain 
is in unknown status.
Line 85:         if (!((getParameters().getIsInternal() && 
checkStorageDomainStatus(StorageDomainStatus.Active,
Line 86:                 StorageDomainStatus.Unknown)) || 
checkStorageDomainStatus(StorageDomainStatus.Active))) {
Line 87:             return false;
Line 88:         }
in loops
Line 89: 
Line 90:         if (!getParameters().getIsInternal()
Line 91:                 && getStorageDomain().getStorageDomainType() == 
StorageDomainType.Master) {
Line 92:             List<StorageDomain> domains =


--
To view, visit http://gerrit.ovirt.org/12237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1a45098dc4eb2607dd12dabf3c0d526e8bebca7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to