Allon Mureinik has posted comments on this change.
Change subject: engine: Version cleanup
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
Line 61: appendVersionComponent(val, this.revision);
Line 62: return val.toString();
Line 63: }
Line 64:
Line 65: static void appendVersionComponent(StringBuilder val, int
versionNumber) {
I'd make it private in the meanwhile, but it's a matter of taste I guess
Line 66: if (versionNumber > -1) {
Line 67: if (val.length() != 0) {
Line 68: val.append(".");
Line 69: }
Line 63: }
Line 64:
Line 65: static void appendVersionComponent(StringBuilder val, int
versionNumber) {
Line 66: if (versionNumber > -1) {
Line 67: if (val.length() != 0) {
Can this ever happen?
You always init val with "this.major"
Line 68: val.append(".");
Line 69: }
Line 70: val.append(versionNumber);
Line 71: }
--
To view, visit http://gerrit.ovirt.org/12368
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dba498fa54bae997d08e7457dd53eb60a740199
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
