Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: Version cleanup
......................................................................
engine: Version cleanup
- replaced String concatenation with StringBuilder
- replaced reference comparison with strings to StringBuilder length
check
- refactored the version component addition to a new method
appendVersionComponent
Change-Id: I7dba498fa54bae997d08e7457dd53eb60a740199
Signed-off-by: Laszlo Hornyak <lhorn...@redhat.com>
---
M
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
1 file changed, 14 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/12368/1
diff --git
a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
index 279889e..b46c29b 100644
---
a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
+++
b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
@@ -52,18 +52,23 @@
}
public String getValue() {
- String val = "";
+ final StringBuilder val = new StringBuilder();
if (this.major > -1)
- val += this.major;
- if (this.minor > -1)
- val += (val != "" ? "." : "") + this.minor;
- if (this.build > -1)
- val += (val != "" ? "." : "") + this.build;
- if (this.revision > -1)
- val += (val != "" ? "." : "") + this.revision;
+ val.append(this.major);
+ appendVersionComponent(val, this.minor);
+ appendVersionComponent(val, this.build);
+ appendVersionComponent(val, this.revision);
+ return val.toString();
+ }
- return val;
+ static void appendVersionComponent(StringBuilder val, int versionNumber) {
+ if (versionNumber > -1) {
+ if (val.length() != 0) {
+ val.append(".");
+ }
+ val.append(versionNumber);
+ }
}
public void setValue(String value) {
--
To view, visit http://gerrit.ovirt.org/12368
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dba498fa54bae997d08e7457dd53eb60a740199
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
