Liron Aravot has posted comments on this change.

Change subject: core: Add ImagesHandler.filterEditableImageDisks
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 614:         return diskImages;
Line 615:     }
Line 616: 
Line 617:     public static List<DiskImage> 
filterEditableImageDisks(Collection<? extends Disk> listOfDisks) {
Line 618:         return filterImageDisks(listOfDisks, true, true);
previously the calls where with "true, false", now they are with "true, true" - 
is this intendant?
Line 619:     }
Line 620: 
Line 621:     public static List<LunDisk> 
filterDiskBasedOnLuns(Collection<Disk> listOfDisks) {
Line 622:         List<LunDisk> lunDisks = new ArrayList<LunDisk>();


--
To view, visit http://gerrit.ovirt.org/12320
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f766309911d27503dbbb80a07fcc776d9068cd2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to