Tal Nisan has posted comments on this change. Change subject: core: Add ImagesHandler.filterEditableImageDisks ......................................................................
Patch Set 1: (1 inline comment) If I understand you correctly you are saying that the combination of 01, 10 and 11, why bother having a method signature of two booleans then? We can just have one method to filter editable and another one to filter non editable and we can skip the usage of both booleans .................................................... Commit Message Line 11: Most of the commands CDAs refer to images the commands can manipulate in Line 12: some way - which means they must be allowed to snapshot. Line 13: Line 14: This patch contains: Line 15: * A new method, filterEditableImageDisks, as syntactic sugar on top of Hehe, feeling metaphoric today? ;) Line 16: filterImagesHandler. Line 17: * Tests to show it's completely equivalent to: Line 18: filterImageDisks(disks, false, true) Line 19: filterImageDisks(disks, true, false) -- To view, visit http://gerrit.ovirt.org/12320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f766309911d27503dbbb80a07fcc776d9068cd2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
