Ofer Schreiber has posted comments on this change. Change subject: packaging: changed tasks polling in engine-upgrade ......................................................................
Patch Set 2: (1 inline comment) .................................................... File packaging/fedora/setup/engine-upgrade.py Line 909: compensations = getCompensations(dbName) Line 910: logging.debug(MSG_WAITING_RUNNING_TASKS) Line 911: Line 912: if runningTasks or compensations: Line 913: if seconds_waited < MAINTENANCE_TASKS_WAIT_PERIOD: I'm missing something here. This will continue if seconds_waited < MAINTANANCE TASKS_WAIT ? What's the reason for that? Line 914: continue Line 915: Line 916: running_tasks_msg = MSG_TASKS_COMPENSATIONS % ( Line 917: runningTasks, compensations -- To view, visit http://gerrit.ovirt.org/12177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32eaeb2427fcc9c4566ca12bf547d49a308a8937 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
