Alex Lourie has posted comments on this change. Change subject: packaging: changed tasks polling in engine-upgrade ......................................................................
Patch Set 1: (1 inline comment) .................................................... File packaging/fedora/setup/engine-upgrade.py Line 924: retry_counter += 1 Line 925: running_tasks_msg = MSG_TASKS_COMPENSATIONS % ( Line 926: runningTasks, compensations Line 927: ) Line 928: if retry_counter >= MAINTENANCE_TASKS_CYCLES: This behaviour was previously considered unnecessary, so I'd not introduce it again - I mean exiting on a number of counts - we don't limit user on the time spent waiting, as we can't tell how long can this take. So I'd remove the counter and waiting time, otherwise the code looks good. Line 929: # There are still tasks running, so exit and tell to resolve Line 930: # before user continues. Line 931: raise Exception(MSG_TASKS_STILL_RUNNING % running_tasks_msg) Line 932: -- To view, visit http://gerrit.ovirt.org/12177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32eaeb2427fcc9c4566ca12bf547d49a308a8937 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
