Gilad Chaplik has posted comments on this change. Change subject: webadmin: Linit selection of datacenters in new quota ......................................................................
Patch Set 1: (3 inline comments) minor comments .................................................... Commit Message Line 3: AuthorDate: 2013-02-21 17:10:38 +0200 Line 4: Commit: Noam Slomianko <nslom...@redhat.com> Line 5: CommitDate: 2013-02-21 17:10:38 +0200 Line 6: Line 7: webadmin: Linit selection of datacenters in new quota /s/linit/limit Line 8: Line 9: when creating new quota from the datacenter_quota subtab only the Line 10: selected datacenter should be an option for the created quota Line 11: Line 8: Line 9: when creating new quota from the datacenter_quota subtab only the Line 10: selected datacenter should be an option for the created quota Line 11: Line 12: and fixed a possible null pionter exception in a certin race conditions /s/certin/certain Line 13: Line 14: Change-Id: I81c6d13e6ddb704c85593d8ffec317e40a3d3a86 Line 15: Bug-Url: https://bugzilla.redhat.com/911241 .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java Line 189: Line 190: @Override Line 191: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 192: storage_pool selectedDataCenter = (storage_pool) qModel.getDataCenter().getSelectedItem(); Line 193: if(selectedDataCenter == null){ how it can be null? Line 194: return; Line 195: } Line 196: AsyncDataProvider.GetClusterList(new AsyncQuery(this, new INewAsyncCallback() { Line 197: @Override -- To view, visit http://gerrit.ovirt.org/12287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81c6d13e6ddb704c85593d8ffec317e40a3d3a86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslom...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
