Noam Slomianko has posted comments on this change.

Change subject: webadmin: Limit selection of datacenters in new quota
......................................................................


Patch Set 2: Verified

Regarding the null questionL
In the old code SetItems changes SelectedItem to null in an async operation, 
this creates a race contrition.

On the new code it is not guaranteed that SetItems will be called at all, if 
populateDataCenter is false it's the calling methods responsibility to do it.

--
To view, visit http://gerrit.ovirt.org/12287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81c6d13e6ddb704c85593d8ffec317e40a3d3a86
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to