Liron Aravot has uploaded a new change for review.
Change subject: core: AddVmFromSnapshot - avoid early end method run
......................................................................
core: AddVmFromSnapshot - avoid early end method run
When adding vm as a clone of snapshot, the vm id should be set as
the entity id for the child commands parameters - this prevent a
situation in which the end method is called too early.
NOTE: seems like the MoveOrCopyImageGroupParameters class might be
re-factored so that in a case of given ContainerId, it will be set as the
entity id - but that's not in the scope of this change.
Change-Id: I7a536cb3c530fd9caa0b121830481604c0558d53
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/67/12267/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
index ea76557..187f0a7 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
@@ -107,6 +107,7 @@
params.setUseCopyCollapse(true);
params.setSourceDomainId(srcStorageDomainId);
params.setWipeAfterDelete(diskImage.isWipeAfterDelete());
+ params.setEntityId(getVmId());
params.setParentParameters(getParameters());
params.setParentCommand(parentCommandType);
return params;
--
To view, visit http://gerrit.ovirt.org/12267
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a536cb3c530fd9caa0b121830481604c0558d53
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
