Allon Mureinik has uploaded a new change for review.
Change subject: core: Fix dal test logging configuration
......................................................................
core: Fix dal test logging configuration
Fix the logging configuration in the dal module's tests:
* Make sure each category has appenders
* Remove useless categories
* Fix typo in the ErrorHandler
Change-Id: I0432e7618ee8d9b7671a025b6fee0fad49a161c8
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M backend/manager/modules/dal/src/test/resources/log4j.xml
1 file changed, 8 insertions(+), 29 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/12081/1
diff --git a/backend/manager/modules/dal/src/test/resources/log4j.xml
b/backend/manager/modules/dal/src/test/resources/log4j.xml
index c8bdf85..0d2d64e 100644
--- a/backend/manager/modules/dal/src/test/resources/log4j.xml
+++ b/backend/manager/modules/dal/src/test/resources/log4j.xml
@@ -9,39 +9,14 @@
<!-- ============================== -->
<appender name="CONSOLE" class="org.apache.log4j.ConsoleAppender">
- <errorHandler class="org.apache.log4j.helpers..OnlyOnceErrorHandler"/>
+ <errorHandler class="org.apache.log4j.helpers.OnlyOnceErrorHandler"/>
<param name="Target" value="System.out"/>
- <param name="Threshold" value="INFO"/>
<layout class="org.apache.log4j.PatternLayout">
<!-- The default pattern: Date Priority [Category] Message\n -->
<param name="ConversionPattern" value="%d{ABSOLUTE} %-5p [%c{1}]
%m%n"/>
</layout>
</appender>
-
- <!-- ================ -->
- <!-- Limit categories -->
- <!-- ================ -->
-
- <!-- Limit the com.sun category to INFO as its FINE is verbose -->
- <category name="com.sun">
- <priority value="INFO"/>
- </category>
-
- <!-- Limit the sun category to INFO as its FINE is verbose -->
- <category name="sun">
- <priority value="INFO"/>
- </category>
-
- <!-- Limit the javax.xml.bind category to INFO as its FINE is verbose -->
- <category name="javax.xml.bind">
- <priority value="INFO"/>
- </category>
-
- <!-- Limit the org.springframework categories -->
- <category name="org.springframework">
- <priority value="WARN"/>
- </category>
<!-- ======================= -->
<!-- oVirt categories -->
@@ -50,16 +25,19 @@
<!--TOP configuration for all oVirt categories -->
<category name="org.ovirt.engine.core" additivity="false">
<priority value="INFO"/>
+ <appender-ref ref="CONSOLE"/>
</category>
- <category name="org.ovirt.engine.core.utils.ejb.EJBUtilsStrategy" >
+ <category name="org.ovirt.engine.core.utils.ejb.EJBUtilsStrategy"
additivity="false" >
<priority value="ERROR"/>
- </category>
+ <appender-ref ref="CONSOLE"/>
+ </category>
<!--Postgres causes lots of verboe messages in INFO level:
"Added default SqlReturnResultSet parameter named #result-set-1"-->
<category
name="org.ovirt.engine.core.dal.dbbroker.PostgresDbEngineDialect$PostgresJdbcTemplate">
- <priority value="WARN"/>
+ <priority value="WARN"/>
+ <appender-ref ref="CONSOLE"/>
</category>
<!-- ======================= -->
@@ -73,6 +51,7 @@
setting a default via ${jboss.server.log.threshold:WARN} will not
work.
-->
<priority value="WARN"/>
+ <appender-ref ref="CONSOLE"/>
</root>
--
To view, visit http://gerrit.ovirt.org/12081
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0432e7618ee8d9b7671a025b6fee0fad49a161c8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
