Allon Mureinik has uploaded a new change for review.

Change subject: core: PostgresDataTypeFactory logger
......................................................................

core: PostgresDataTypeFactory logger

Changed PostgresDataTypeFactory to use the standard
org.ovirt.engine.core.utils.log.Log instead of using slf4j directly.

Change-Id: Icba239ed28e992f905b12bfdc6fdbce18ffe40f6
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M 
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java
1 file changed, 6 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/12080/1

diff --git 
a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java
 
b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java
index 2445f76..e30a87a 100644
--- 
a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java
+++ 
b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java
@@ -12,11 +12,11 @@
 import org.dbunit.ext.postgresql.IntervalType;
 import org.dbunit.ext.postgresql.PostgresqlDataTypeFactory;
 import org.dbunit.ext.postgresql.UuidType;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import org.ovirt.engine.core.utils.log.Log;
+import org.ovirt.engine.core.utils.log.LogFactory;
 
 public class PostgresDataTypeFactory extends DefaultDataTypeFactory {
-    private static final Logger logger = 
LoggerFactory.getLogger(PostgresqlDataTypeFactory.class);
+    private static final Log logger = 
LogFactory.getLog(PostgresqlDataTypeFactory.class);
     private static final Collection<String> DATABASE_PRODUCTS = 
Arrays.asList(new String[] { "PostgreSQL" });
 
     @Override
@@ -26,7 +26,7 @@
 
     @Override
     public DataType createDataType(int sqlType, String sqlTypeName) throws 
DataTypeException {
-        logger.debug("createDataType(sqlType={}, sqlTypeName={})",
+        logger.debugFormat("createDataType(sqlType={}, sqlTypeName={})",
                 String.valueOf(sqlType), sqlTypeName);
 
         if (sqlType == Types.OTHER)
@@ -41,9 +41,8 @@
             else {
                 // Finally check whether the user defined a custom datatype
                 if (isEnumType(sqlTypeName)) {
-                    if (logger.isDebugEnabled())
-                        logger.debug("Custom enum type used for sqlTypeName {} 
(sqlType '{}')",
-                                new Object[] { sqlTypeName, new 
Integer(sqlType) });
+                    logger.debugFormat("Custom enum type used for sqlTypeName 
{} (sqlType '{}')",
+                            new Object[] { sqlTypeName, new Integer(sqlType) 
});
                     return new GenericEnumType(sqlTypeName);
                 }
             }


--
To view, visit http://gerrit.ovirt.org/12080
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icba239ed28e992f905b12bfdc6fdbce18ffe40f6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to