liron aravot has posted comments on this change.
Change subject: core:Direct lun disk should only log finish action
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 330: }
Line 331: Backend.getInstance().EndAction(VdcActionType.RemoveImage,
getParameters().getImagesParameters().get(0));
Line 332: setSucceeded(true);
Line 333: }
Line 334:
shouldn't you override the log method here as well?
Line 335: @Override
Line 336: public AuditLogType getAuditLogTypeValue() {
Line 337: switch (getActionState()) {
Line 338: case EXECUTE:
--
To view, visit http://gerrit.ovirt.org/12011
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22b145fbc12481e40eaa8329eb8ce35f7c39a320
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
