Liron Aravot has posted comments on this change.
Change subject: core:Direct lun disk should only log finish action
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 516:
Line 517: @Override
Line 518: protected void endSuccessfully() {
Line 519: super.endSuccessfully();
Line 520: setCommandShouldBeLogged(true);
why not put that in the c'tor and avoid overriding those methods?
will it be logged without it during execute phase?
Line 521: }
Line 522:
Line 523: @Override
Line 524: protected void endWithFailure() {
--
To view, visit http://gerrit.ovirt.org/12011
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22b145fbc12481e40eaa8329eb8ce35f7c39a320
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
