Gilad Chaplik has posted comments on this change.

Change subject: engine: Support for gluster asynchronous tasks(WIP)
......................................................................


Patch Set 2: (1 inline comment)

probably you had this talk on engine devel or sth, but remind me why we aren't 
using AsyncTaskManager? or at least deriving from it?

Thanks :)

....................................................
File backend/manager/dbscripts/job_sp.sql
Line 495: 
Line 496: ----------------------------------------------------
Line 497: -- Gets Step entities list from Step table by external id
Line 498: ----------------------------------------------------
Line 499: Create or replace FUNCTION GetStepsByJobId(v_external_id UUID)
CMIIW, we must have this method.
Line 500: RETURNS SETOF step
Line 501: AS $procedure$
Line 502: BEGIN
Line 503:     RETURN QUERY SELECT step.*


--
To view, visit http://gerrit.ovirt.org/11840
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a56785edef091bce74e2b7b0ba9a3314f1397f1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to