Alon Bar-Lev has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File
backend/manager/modules/root/src/main/java/org/ovirt/engine/core/GetAttachmentServlet.java
Line 23:
Line 24: response.setContentType(contentType);
Line 25: response.setHeader("Content-Disposition", "attachment;
filename=\"" + fileName + "\"");
Line 26: response.setHeader("Cache-Control", "no-cache,
must-revalidate"); //disable caching HTTP/1.1
Line 27: response.setHeader("Expires", "Sat, 26 Jul 1997 05:00:00
GMT"); //disable caching HTTP/1.0
I would add cache=true/false as a parameter.
Line 28:
Line 29: response.getWriter().println(content);
Line 30: }
Line 25: response.setHeader("Content-Disposition", "attachment;
filename=\"" + fileName + "\"");
Line 26: response.setHeader("Cache-Control", "no-cache,
must-revalidate"); //disable caching HTTP/1.1
Line 27: response.setHeader("Expires", "Sat, 26 Jul 1997 05:00:00
GMT"); //disable caching HTTP/1.0
Line 28:
Line 29: response.getWriter().println(content);
Any reason why not to use output stream? Much less errors.... as we
discussed... it does raise the IOException if there is an error.
*AND*, will able to add binary data as well... add a encoding= parameter to
servlet which can be either text or base64... :)
Line 30: }
....................................................
File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
Line 48: </servlet-mapping>
Line 49:
Line 50: <!-- Servlet to serve config files for console client -->
Line 51: <servlet>
Line 52: <servlet-name>ConsoleConfigServlet</servlet-name>
Why not call this GetAttachment? It has nothing to do with console...
Line 53:
<servlet-class>org.ovirt.engine.core.GetAttachmentServlet</servlet-class>
Line 54: </servlet>
Line 55: <servlet-mapping>
Line 56: <servlet-name>ConsoleConfigServlet</servlet-name>
Line 53:
<servlet-class>org.ovirt.engine.core.GetAttachmentServlet</servlet-class>
Line 54: </servlet>
Line 55: <servlet-mapping>
Line 56: <servlet-name>ConsoleConfigServlet</servlet-name>
Line 57: <url-pattern>/console.vv</url-pattern>
Same...
Line 58: </servlet-mapping>
Line 59:
Line 60: <!-- Documentation: -->
Line 61: <servlet>
--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
