Yair Zaslavsky has posted comments on this change.

Change subject: core: Update StoragePoolValidator test to test GlusterFS.
......................................................................


Patch Set 10: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolValidator.java
Line 47:      */
Line 48:     public ValidationResult 
isGlusterDcAndMatchingCompatiblityVersion() {
Line 49:         if (storagePool.getstorage_pool_type() == StorageType.GLUSTERFS
Line 50:                 && !Config.<Boolean> GetValue
Line 51:                         (ConfigValues.GlusterFsStorageEnabled, 
storagePool.getcompatibility_version().toString())) {
Plase use FeatureSupported here.
Line 52:             return new 
ValidationResult(VdcBllMessages.DATA_CENTER_GLUSTER_STORAGE_NOT_SUPPORTED_IN_CURRENT_VERSION);
Line 53:         }
Line 54:         return ValidationResult.VALID;
Line 55:     }


--
To view, visit http://gerrit.ovirt.org/8836
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4cd98cd06716c31248d8ec4f21a3a6f79f13102
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to