Sahina Bose has posted comments on this change.
Change subject: core: Adding compatibility version support for GlusterFS.
......................................................................
Patch Set 9: (1 inline comment)
Minor suggestion inline
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 315: select
fn_db_add_config_value('OvfItemsCountPerUpdate','100','general');
Line 316: select fn_db_add_config_value('PayloadSize','8192','general');
Line 317: select fn_db_add_config_value('PosixStorageEnabled','false','3.0');
Line 318: select fn_db_add_config_value('PosixStorageEnabled','true','3.1');
Line 319: select fn_db_add_config_value('PosixStorageEnabled','true','3.2');
Entries are ordered by key as per header of the file. Can you place in correct
location?
Line 320: select
fn_db_add_config_value('GlusterFsStorageEnabled','false','3.0');
Line 321: select
fn_db_add_config_value('GlusterFsStorageEnabled','false','3.1');
Line 322: select fn_db_add_config_value('GlusterFsStorageEnabled','true','3.2');
Line 323: select fn_db_add_config_value('PostgresI18NPrefix','','general');
--
To view, visit http://gerrit.ovirt.org/8835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbe47fcd03c8b4874c7f2ceb4d52a7da3c158d00
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
