Allon Mureinik has posted comments on this change.
Change subject: core: Adding compatibility version support for GlusterFS.
......................................................................
Patch Set 11: Looks good to me, but someone else must approve
(1 inline comment)
IMHO, this should be squashed into a larger patch.
On it's own, you're just adding a config value that no-one reads, which does
generate any benefit.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1408: @DefaultValueAttribute("")
Line 1409: SpiceProxyDefault(420),
Line 1410:
Line 1411: @TypeConverterAttribute(Boolean.class)
Line 1412: @DefaultValueAttribute("false")
IIRC, the default is the software version, so this should be true.
Line 1413: GlusterFsStorageEnabled(421),
Line 1414:
Line 1415: Invalid(65535);
Line 1416:
--
To view, visit http://gerrit.ovirt.org/8835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbe47fcd03c8b4874c7f2ceb4d52a7da3c158d00
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
