Yair Zaslavsky has posted comments on this change.
Change subject: core: Don't use commons collections clone method
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/CopyOnAccessMap.java
Line 71: objectOut.writeObject(originalKey);
Line 72: buffer = bufferOut.toByteArray();
Line 73: }
Line 74: catch (IOException exception) {
Line 75: throw new RuntimeException(exception);
I prefer not to introduce the logger , so I favor Juan's approach
Line 76: }
Line 77: finally {
Line 78: if (objectOut != null) {
Line 79: try {
--
To view, visit http://gerrit.ovirt.org/11594
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I218940edb8fbd9e3b10e4bf01dfc84ac84196213
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
