Allon Mureinik has posted comments on this change.
Change subject: core: Don't use commons collections clone method
......................................................................
Patch Set 2: (1 inline comment)
"This is what happens if we try to use a JBoss module instead of dropping
commons-collections in the lib directory of the ear."
This bug seems like a symptom of the above statement, and that many more are on
the way.
Wouldn't the easier approach just to "dropping commons-collections in the lib
directory of the ear."?
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/CopyOnAccessMap.java
Line 71: objectOut.writeObject(originalKey);
Line 72: buffer = bufferOut.toByteArray();
Line 73: }
Line 74: catch (IOException exception) {
Line 75: throw new RuntimeException(exception);
Can we perhaps throw something nicer?
Line 76: }
Line 77: finally {
Line 78: if (objectOut != null) {
Line 79: try {
--
To view, visit http://gerrit.ovirt.org/11594
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I218940edb8fbd9e3b10e4bf01dfc84ac84196213
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
