Libor Spevak has posted comments on this change.
Change subject: webadmin: Failure message popup window text unified
......................................................................
Patch Set 3:
I can change the commit message in the next push.
The original reason of this patch is to make the error message text for Run vs.
RunOnce actions the same:
Error while executing action: {0}
There are several types of error messages, which just wrap output text to error
popup window BODY. From a user point of view is probably the same, if Run,
resp. RunOnce action fails because of unavailable host (canDoAction), though
the implementation is different (one-step action vs. multiple action). But the
error starts with
"Error while executing action:
...
"
resp.
"Error:
...
"
Java code shows, we have several types of messages, I would like to remove the
first from the code:
@DefaultMessage("Error: {0}")
String uiCommonFrontendFailure(String reason);
@DefaultMessage("Error while executing action: {0}")
String uiCommonRunActionFailed(String reason);
@DefaultMessage("Error while executing action {0}: {1}")
String uiCommonRunActionExecutionFailed(String action, String reason);
@DefaultMessage("Error while executing query: {0}")
String uiCommonRunQueryFailed(String reason);
--
To view, visit http://gerrit.ovirt.org/11860
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a9b71e1a3e6f97342184e71ffcbb7cee1df4e9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
