Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated fetching db params from pgpass
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File src/__main__.py
Line 189: self['pg_dbport'] = self._get_pg_var('port') or pg_dbport
Line 190: except Exception, e:
Line 191: logging.debug(str(e))
Line 192:
Line 193: def _get_pg_var(self, dbconf_param, user=None):
Why do we need the user?
Line 194: '''
Line 195: Provides a mechanism to extract information from .pgpass.
Line 196: '''
Line 197: field = {'pass': 4, 'admin': 3, 'host': 0, 'port': 1}
--
To view, visit http://gerrit.ovirt.org/11826
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28e0d1da86bc1a8c7ba909aad3cd541bab80e36
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
