Muli Salem has posted comments on this change.

Change subject: core: Remove Mac Addresses When DC Removed
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
Line 84: 
Line 85:         getStoragePoolDAO().remove(getStoragePool().getId());
Line 86: 
Line 87:         setSucceeded(true);
Line 88: 
Done
Line 89:         if (getSucceeded()) {
Line 90:             MacPoolManager.getInstance().freeMacs(macsToRemove);
Line 91:         }
Line 92:     }


....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoDbFacadeImpl.java
Line 14: import org.springframework.jdbc.core.simple.ParameterizedRowMapper;
Line 15: 
Line 16: public class VmNetworkInterfaceDaoDbFacadeImpl extends BaseDAODbFacade 
implements VmNetworkInterfaceDao {
Line 17: 
Line 18:     private static final int MAC_COLUMN = 1;
Done
Line 19: 
Line 20:     protected final ParameterizedRowMapper<VmNetworkInterface> mapper =
Line 21:             new ParameterizedRowMapper<VmNetworkInterface>() {
Line 22:                 @Override


....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDao.java
Line 70:      */
Line 71:     List<VmNetworkInterface> getAllForTemplatesByNetwork(Guid 
networkId);
Line 72: 
Line 73:     /**
Line 74:      * Retrieves the MAC addresses of the Vms in the given Storage 
Pool.
Done
Line 75:      *
Line 76:      * @param storagePoolId
Line 77:      *            the Storage Pool
Line 78:      * @return the list of MAC addresses


--
To view, visit http://gerrit.ovirt.org/11796
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6d473b4921de12fbd68bdaf2fc058662ed3a06
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to