Vojtech Szocs has posted comments on this change. Change subject: webadmin: introduce NullableFrontendActionAsyncCallback ......................................................................
Patch Set 3: Looks good to me, but someone else must approve This patch looks good to me. Callers of RunAction can simply pass null as callback, and Frontend will internally use the singleton null object represented by NULLABLE_ASYNC_CALLBACK, which makes code a bit more readable (less null checks). I think we should consider refactoring the whole Frontend class and writing unit tests to guard against regressions. -- To view, visit http://gerrit.ovirt.org/11734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0cf37a9f4ffb973a3791323596af6d97c7365cb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
