Arik Hadas has posted comments on this change. Change subject: webadmin: introduce NullableFrontendActionAsyncCallback ......................................................................
Patch Set 2: Kanagaraj, I agree that it's better to pass null from outside of Frontend class. it was done in patch #3 but inside this class, it's better to replace null with nullable object. handling null values is considered bad practice because people intend to forget null checks and the code is less readable (you also mentioned the missing null check at onFailure) -- To view, visit http://gerrit.ovirt.org/11734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0cf37a9f4ffb973a3791323596af6d97c7365cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
