Sahina Bose has posted comments on this change.

Change subject: restapi: Rest API for brick advanced details
......................................................................


Patch Set 3: (3 inline comments)

Thanks, Michael. Shall add statistics for usage details of brick.

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2924:     <xs:sequence>
Line 2925:       <xs:element name="host_name" type="xs:string" minOccurs="0" 
maxOccurs="1"/>
Line 2926:       <xs:element name="client_port" type="xs:int" minOccurs="0" 
maxOccurs="1"/>
Line 2927:       <xs:element name="bytes_read" type="xs:int" minOccurs="0" 
maxOccurs="1"/>
Line 2928:       <xs:element name="bytes_written" type="xs:int" minOccurs="0" 
maxOccurs="1"/>
Will do.
Line 2929:     </xs:sequence>
Line 2930:   </xs:complexType>
Line 2931: 
Line 2932:   <xs:element name="gluster_clients" type="GlusterClients"/>


Line 2944:     </xs:extension>
Line 2945:     </xs:complexContent>
Line 2946:   </xs:complexType>
Line 2947: 
Line 2948:   <xs:element name="gluster_memory_pool" type="GlusterMemoryPool"/>
Ok.
Line 2949:   <xs:complexType name="GlusterMemoryPool">
Line 2950:     <xs:sequence>
Line 2951:       <xs:element name="name" type="xs:string" minOccurs="0" 
maxOccurs="1"/>
Line 2952:       <xs:element name="hot_count" type="xs:int" minOccurs="0" 
maxOccurs="1"/>


Line 3020:           <xs:element name="block_size" type="xs:int" minOccurs="0" 
maxOccurs="1"/>
Line 3021:           <xs:element name="mnt_options" type="xs:string" 
minOccurs="0" maxOccurs="1"/>
Line 3022:           <xs:element name="fs_name" type="xs:string" minOccurs="0" 
maxOccurs="1"/>
Line 3023:           <xs:element name="clients" type="GlusterClients" 
minOccurs="0" maxOccurs="1" />
Line 3024:           <xs:element name="memory_info" 
type="GlusterBrickMemoryInfo" minOccurs="0" maxOccurs="1"/>
I'm not sure I understand. Do you mean I have to provide a ref to memory_info 
here instead of type="GlusterBrickMemoryInfo"
Line 3025:         </xs:sequence>
Line 3026:       </xs:extension>
Line 3027:     </xs:complexContent>
Line 3028:   </xs:complexType>


--
To view, visit http://gerrit.ovirt.org/11391
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie219c7cf59fec8a21a54f34959ee5966eed7d524
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to