Juan Hernandez has posted comments on this change. Change subject: core: Create artifact for PostgreSQL module ......................................................................
Patch Set 1: (2 inline comments) .................................................... File Makefile Line 423: @echo "*** Deploying JBoss modules" Line 424: Line 425: # Incompress and install the contents of the modules archive to Line 426: # the directory containing engine modules: Line 427: X=`find "$(MAVEN_OUTPUT_DIR)" -name "dependencies-$(APP_VERSION)*.zip"` && unzip "$$X" -d "$(DESTDIR)$(PKG_JBOSS_MODULES)" See line 266 and commit 8bce04, that explains why we do this in this way. Line 428: Line 429: install_service: Line 430: @echo "*** Deploying service" Line 431: .................................................... File packaging/fedora/spec/ovirt-engine.spec.in Line 486 Line 487 Line 488 Line 489 Line 490 The PostgreSQL JDBC driver has to be deployed as a module. We used to deploy it and other modules like this, in the RPM. We still need to deploy it, but now it is done in the Makefile, so these lines are no longer needed. -- To view, visit http://gerrit.ovirt.org/11685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad7ee2264fde3badf7d242fe3a20874e1d24d6bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
