Liron Aravot has posted comments on this change.
Change subject: core: Change CommandBase validate method to accept multiple
results
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 147: isStoragePoolMatching(vm) &&
Line 148:
performImagesChecks(vm.getStoragePoolId()) &&
Line 149:
validate(getSnapshotValidator().vmNotDuringSnapshot(vm.getId()),
Line 150:
getSnapshotValidator().vmNotInPreview(vm.getId()),
Line 151: new
VmValidator(vm).vmNotLocked());
I've meant to all the validations that are sent to the validate method
Line 152: }
Line 153:
Line 154: return returnValue;
Line 155: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1508: for (String variableReplacement :
validationResult.getVariableReplacements()) {
Line 1509: addCanDoActionMessage(variableReplacement);
Line 1510: }
Line 1511: }
Line 1512: return false;
yeah, but we already verified 5 validations and return false on the first
one..if you already validated 5, why not show that info as well?
Line 1513: }
Line 1514: }
Line 1515: return true;
Line 1516: }
--
To view, visit http://gerrit.ovirt.org/11557
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64a18ec0e6c677192dbd86bf0b38de46e539d138
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
