Allon Mureinik has posted comments on this change. Change subject: core: Change CommandBase validate method to accept multiple results ......................................................................
Patch Set 1: @Tal: not exaclty before the change, we would do something like this: validate(a) && validate(b) if the 1st validate fails, the second isn't called - which means we don't even PRODUCE the b validation result. After this patch, we call validate(a,b) - we need to PRODUCE both validation results, and only short circuit on their isValid() method. -- To view, visit http://gerrit.ovirt.org/11557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64a18ec0e6c677192dbd86bf0b38de46e539d138 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
