Liron Aravot has posted comments on this change.
Change subject: core: ImagesHandler: Remove SD status validation
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
Line 154:
Line 155: // Check the source storage domains exist and are up
Line 156: for (Guid sdId :
ImagesHandler.getAllDomainsIds(getDisksBasedOnImage())) {
Line 157: StorageDomainValidator sdValidator = new
StorageDomainValidator(getStorageDomain(sdId));
Line 158: if (validate(sdValidator.isDomainExistAndActive())) {
shouldn't this be !validate?
Line 159: return false;
Line 160: }
Line 161: }
Line 162:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 190:
Line 191: protected boolean
validateStorageDoaminsActive(Collection<DiskImage> disksList) {
Line 192: for (Guid sdId : ImagesHandler.getAllDomainsIds(disksList)) {
Line 193: StorageDomainValidator sdValidator = new
StorageDomainValidator(getStorageDomain(sdId));
Line 194: if (validate(sdValidator.isDomainExistAndActive())) {
shouldn't be !validate?
Line 195: return false;
Line 196: }
Line 197: }
Line 198: return true;
--
To view, visit http://gerrit.ovirt.org/11487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id632168da64832a9c9393b81e552112240e974c0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
