Tal Nisan has posted comments on this change. Change subject: core: ImagesHandler: Remove SD status validation ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java Line 292: && validate(snapshotValidator.vmNotInPreview(getVmId())) Line 293: && validate(vmValidator.vmNotDuringMigration()) Line 294: && validate(vmValidator.vmNotRunningStateless()) Line 295: && validate(vmValidator.vmNotIlegal()) Line 296: && validateStorageDoaminsActive(disksList) This pattern is starting to return more and more, we might wanna consider changing the validate method to validate(ValidationResult... validationResult) That way it will look like validate(snapshotValidator.vmNotDuringSnapshot(getVmId()), snapshotValidator.vmNotInPreview(getVmId()), vmValidator.vmNotDuringMigration() ... Line 297: && ImagesHandler.PerformImagesChecks( Line 298: getReturnValue().getCanDoActionMessages(), Line 299: getVm().getStoragePoolId(), Line 300: Guid.Empty, -- To view, visit http://gerrit.ovirt.org/11487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id632168da64832a9c9393b81e552112240e974c0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
