Allon Mureinik has posted comments on this change.
Change subject: core:(WIP) Use storage validator when adding a new VM
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 172:
reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_NOT_MATCH.toString());
Line 173: returnValue = false;
Line 174: } else {
Line 175: for (storage_domains domain : destStorages) {
Line 176: if (validate(new
StorageDomainValidator(getStorageDomain()).isDomainWithinThresholds())) {
should be if(!validate...
Line 177: return false;
Line 178: }
Line 179: if
(!StorageDomainSpaceChecker.hasSpaceForRequest(domain,
Line 180: getNeededDiskSize(domain.getId()))) {
--
To view, visit http://gerrit.ovirt.org/11512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee28506dec042fe60e9691d41458ad54a83b2f0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
