Maor Lipchuk has uploaded a new change for review.
Change subject: core:(WIP) Use storage validator when adding a new VM
......................................................................
core:(WIP) Use storage validator when adding a new VM
Use storage validator instead regular check when adding a new VM.
Tests should be reveisited.
Change-Id: I6ee28506dec042fe60e9691d41458ad54a83b2f0
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/11512/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
index 26d2715..e801eee 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
@@ -173,11 +173,10 @@
returnValue = false;
} else {
for (storage_domains domain : destStorages) {
- if (!StorageDomainSpaceChecker.isWithinThresholds(domain))
{
- returnValue = false;
-
reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW.toString());
- break;
- } else if
(!StorageDomainSpaceChecker.hasSpaceForRequest(domain,
+ if (validate(new
StorageDomainValidator(getStorageDomain()).isDomainWithinThresholds())) {
+ return false;
+ }
+ if (!StorageDomainSpaceChecker.hasSpaceForRequest(domain,
getNeededDiskSize(domain.getId()))) {
returnValue = false;
reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW.toString());
--
To view, visit http://gerrit.ovirt.org/11512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ee28506dec042fe60e9691d41458ad54a83b2f0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
