Arik Hadas has uploaded a new change for review.
Change subject: core: revert change If615a9d9
......................................................................
core: revert change If615a9d9
In patch If615a9d9 the execution context of SetNonOperationalVdsCommand
changed to async if it triggered migrations.
This patch change its execution context back to sync. migrations that
will be triggered from SetNonOperationalCommand will be executed as
different jobs (it will be pushed in a different patch), thus resolving
bug 888199 without making the set-non-operational command to be async
(this command shouldn't be async, as the host become non-operational
right after the sync part, independently from the triggered migrations)
Change-Id: I91eb9e84d0ff4ce6a0c8390dc973c3f8822a0c8c
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/69/11369/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
index 7be116f..1309d2b 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
@@ -2,7 +2,6 @@
import java.util.Map.Entry;
-import org.ovirt.engine.core.bll.job.ExecutionHandler;
import org.ovirt.engine.core.common.AuditLogType;
import org.ovirt.engine.core.common.action.SetNonOperationalVdsParameters;
import org.ovirt.engine.core.common.businessentities.NonOperationalReason;
@@ -61,12 +60,6 @@
}
setSucceeded(true);
-
- // if there's VM(s) in this VDS which is migrating, mark this command
as async
- // as the migration(s) is a step of this job, so this job must not be
cleaned yet
- if (isVmsExist()) {
- ExecutionHandler.setAsyncJob(getExecutionContext(), true);
- }
}
@Override
--
To view, visit http://gerrit.ovirt.org/11369
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91eb9e84d0ff4ce6a0c8390dc973c3f8822a0c8c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
