Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Cleanup of Frontend class
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
Line 476: /**
Line 477: * @deprecated Please use async runAction instead, sync
operations are not supported
Line 478: */
Line 479: @Deprecated
Line 480: public static void RunAction(final VdcActionType actionType,
final VdcActionParametersBase parameters) {
so delete it/or leave the signature.
since it's sync it should return value somehow...
Line 481: logger.warning("Sync RunAction is invoked, this is not
supported! replace the call with the async method!"); //$NON-NLS-1$
Line 482: dumpActionDetails(actionType, parameters);
Line 483:
Line 484: GenericApiGWTServiceAsync service =
GenericApiGWTServiceAsync.Util.getInstance();
Line 558: /**
Line 559: * @deprecated Please use async RunMultipleAction instead, sync
operations are not supported
Line 560: */
Line 561: @Deprecated
Line 562: public static void RunMultipleAction(VdcActionType actionType,
same.
Line 563: ArrayList<VdcActionParametersBase> parameters) {
Line 564: RunMultipleAction(actionType, parameters, null, null);
Line 565: }
Line 566:
Line 788: /**
Line 789: * @deprecated Not supported
Line 790: */
Line 791: @Deprecated
Line 792: public static RegistrationResult RegisterQuery(VdcQueryType
queryType,
I don't understand you... you first mark it as deprecated, then remove it all
over and then delete it? too many steps...
Line 793: VdcQueryParametersBase paramenters) {
Line 794: // TODO Auto-generated method stub
Line 795: return null;
Line 796: }
--
To view, visit http://gerrit.ovirt.org/11268
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2799eed79b4534d103fbbc53a6658ecc950c43f0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
