Tal Nisan has posted comments on this change.
Change subject: webadmin: Cleanup of Frontend class
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
Line 476: /**
Line 477: * @deprecated Please use async runAction instead, sync
operations are not supported
Line 478: */
Line 479: @Deprecated
Line 480: public static void RunAction(final VdcActionType actionType,
final VdcActionParametersBase parameters) {
Yes, it's the sync run action, not supported and return an empty return value
just which is not used anyway nowhere in the code
Line 481: logger.warning("Sync RunAction is invoked, this is not
supported! replace the call with the async method!"); //$NON-NLS-1$
Line 482: dumpActionDetails(actionType, parameters);
Line 483:
Line 484: GenericApiGWTServiceAsync service =
GenericApiGWTServiceAsync.Util.getInstance();
Line 558: /**
Line 559: * @deprecated Please use async RunMultipleAction instead, sync
operations are not supported
Line 560: */
Line 561: @Deprecated
Line 562: public static void RunMultipleAction(VdcActionType actionType,
Yes, it's the sync run action, not supported and return an empty return value
just which is not used anyway nowhere in the code
Line 563: ArrayList<VdcActionParametersBase> parameters) {
Line 564: RunMultipleAction(actionType, parameters, null, null);
Line 565: }
Line 566:
Line 788: /**
Line 789: * @deprecated Not supported
Line 790: */
Line 791: @Deprecated
Line 792: public static RegistrationResult RegisterQuery(VdcQueryType
queryType,
Yes, but some of the models still use it, I wanted to clean other stuff in this
patch, the rest will be remove after I will submit a test suite for the
Frontend class
Line 793: VdcQueryParametersBase paramenters) {
Line 794: // TODO Auto-generated method stub
Line 795: return null;
Line 796: }
Line 797:
Line 798: /**
Line 799: * @deprecated Not supported
Line 800: */
Line 801: @Deprecated
Same as above
Line 802: public static RegistrationResult RegisterSearch(String
searchString,
Line 803: SearchType entityType, int searchPageSize) {
Line 804: // TODO Auto-generated method stub
Line 805: return null;
--
To view, visit http://gerrit.ovirt.org/11268
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2799eed79b4534d103fbbc53a6658ecc950c43f0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
