Sahina Bose has posted comments on this change.
Change subject: gluster: Improved audit log messages
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
Line 739: } else if
(!existingOption.getValue().equals(fetchedOption.getValue())) {
Line 740: logAuditMessage(existingVolume.getClusterId(),
existingVolume, null,
Line 741:
AuditLogType.GLUSTER_VOLUME_OPTION_CHANGED_FROM_CLI,
Line 742: ENTITY_OPTION,
Line 743: fetchedOption.toString());
Should the server log messages be changed too? Also, maybe a good idea to log
what the previous value was for change in option
Line 744: log.infoFormat("Value of option {0} of volume {1}
changed from {2} to {3} from CLI. Updating engine DB accordingly.",
Line 745: existingOption.getKey(),
Line 746: existingVolume.getName(),
Line 747: existingOption.getValue(),
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 575: GLUSTER_VOLUME_OPTION_SET_FROM_CLI=Detected new option ${option} on
volume ${glusterVolumeName} of cluster ${VdsGroupName}, and added it to engine
DB.
Line 576: GLUSTER_VOLUME_OPTION_CHANGED_FROM_CLI=Detected change in option
${option} on volume ${glusterVolumeName} of cluster ${VdsGroupName}, and
updated it to engine DB.
Line 577: GLUSTER_VOLUME_OPTION_RESET_FROM_CLI=Detected reset option ${option}
on volume ${glusterVolumeName} of cluster ${VdsGroupName}, and removed it from
engine DB.
Line 578: GLUSTER_VOLUME_PROPERTIES_CHANGED_FROM_CLI=Detected changes in
properties of volume ${glusterVolumeName} of cluster ${VdsGroupName}, and
updated the same in engine DB.
Line 579: GLUSTER_VOLUME_BRICK_ADDED_FROM_CLI=Detected new brick ${brick} on
volume ${glusterVolumeName} of cluster ${VdsGroupName}, and added it to engine
DB.
typo - "removed it" instead of "removed in"
Line 580: GLUSTER_VOLUME_BRICK_REMOVED_FROM_CLI=Detected brick ${brick} removed
from Volume ${glusterVolumeName} of cluster ${VdsGroupName}, and removed in
from engine DB.
Line 581: GLUSTER_SERVER_REMOVED_FROM_CLI=Detected server ${VdsName} removed
from Cluster ${VdsGroupName}, and removed it from engine DB.
Line 582: GLUSTER_VOLUME_STARTED_FROM_CLI=Detected that Volume
${glusterVolumeName} of Cluster ${VdsGroupName} was started, and updated engine
DB with it's new status.
--
To view, visit http://gerrit.ovirt.org/11263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50396fb952001a65fa63e62e94b1fb8dc79b0858
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
