Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Improved audit log messages ......................................................................
gluster: Improved audit log messages The older messages logged by GlusterManager indicated that some action was performed "from gluster cli". While this is true for most cases, it can some times be misleading if some change is done implicitly by glusterfs. Hence changing the messages to make them more generic. Also added the cluster name to the messages. e.g. "Gluster Volume <volname> was created from gluster CLI. Now added to engine DB as well." changed to "Detected new volume <volname> on cluster <clustername>, and added it to engine DB" Also removed the wrapper methods for audit logging, to make use of the newly introduced GlusterAuditLogUtil. Change-Id: I50396fb952001a65fa63e62e94b1fb8dc79b0858 Signed-off-by: Shireesh Anjal <san...@redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0380_gluster_option_changed_event.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 6 files changed, 74 insertions(+), 99 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50396fb952001a65fa63e62e94b1fb8dc79b0858 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
